-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable esbuild in the Node.js builder #307
Conversation
… remove garbage lockfile left by npm 7
… package.json options
Super excited to see this go green. |
This would be really nice |
@mildaniel any update on this? 🙏 |
@mildaniel please finish this!🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, missed cases for download_dependencies == false.
Added a full truth table for each possible combination.
Let me know if you have any question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for addressing the comments!
Taking over the PR from #252. Thank you @gojko for the contribution!
Description from the original PR:
Issue #, if available:
Solves the following issues or makes them obsolete
Description of changes:
Support for ESBuild bundler running as part of the Nodejs NPM workflow, providing the following benefits:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.