fix: respect lockfile when building Node code #317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torresxb1
commented
Jan 21, 2022
torresxb1
commented
Jan 21, 2022
mildaniel
reviewed
Jan 21, 2022
torresxb1
force-pushed
the
respect-lockfile
branch
from
7c41fb8 to
2b7c488
Compare
torresxb1
commented
Jan 21, 2022
mildaniel
approved these changes
Jan 25, 2022
hawflau
reviewed
Jan 26, 2022
| lockfile_path = osutils.joinpath(source_dir, "package-lock.json") | ||
| shrinkwrap_path = osutils.joinpath(source_dir, "npm-shrinkwrap.json") | ||
|
|
||
| if osutils.file_exists(lockfile_path) or osutils.file_exists(shrinkwrap_path): |
There was a problem hiding this comment.
Question - do we want to check if npm ci is available? npm ci is available since npm 6.x and nodejs12 comes with npm6.9+. nodejs10 is going to be deprecated in Lambda pretty soon. It seems safe but we might want to confirm.
There was a problem hiding this comment.
Looks like we already have a PR out to remove Node10 support #319 and Lambda is dropping all support very soon too (Feb 14) https://docs.aws.amazon.com/lambda/latest/dg/runtime-support-policy.html. We could potentially add a condition to check the npm version, fallback to npm install if needed and remove it after that date.
|
Going to close this PR and continue in #338. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
If package-lock.json is found, copies it over and uses npm ci instead of npm install.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.