Skip to content

Add Github Manual workflow to bump version #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

hanwen-pcluste
Copy link
Contributor

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hanwen-pcluste hanwen-pcluste requested review from a team as code owners July 1, 2024 20:55
run: ./util/bump-version.sh ${{ inputs.pcluster-version }}

- name: Create a Pull Request
uses: peter-evans/create-pull-request@v6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didnt catch it before. But are we sure we want to use a 3rd party git-repo and not this one https://github.com/marketplace/actions/github-action-for-creating-pull-requests?

Copy link
Contributor Author

@hanwen-pcluste hanwen-pcluste Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current one is more popular https://github.com/marketplace/actions/create-pull-request

I think both of them are third party

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the link for the one you are using https://github.com/marketplace/actions/create-pull-request

@hanwen-pcluste hanwen-pcluste merged commit 77ee87e into aws:develop Jul 2, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants