Skip to content

[Shutdown] Kill slurmd and slurmstepd before shutting #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gmarciani
Copy link
Contributor

Description of changes

[Shutdown] Kill slurmd and slurmstepd before shutting down to prevent shutdown hanging on these running processes, which is an unexpected behaviour observed in Ubuntu24.04.

Tests

PENDING test_error_handling

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

… shutdown hanging on these running processes, which is an unexpected behaviour observed in Ubuntu24.04.
@gmarciani gmarciani force-pushed the wip/mgiacomo/3130/kill-before-shutdown-1 branch from 16b3724 to 7514b94 Compare March 24, 2025 13:47
hanwen-cluster
hanwen-cluster previously approved these changes Mar 24, 2025
@hanwen-cluster hanwen-cluster changed the base branch from develop to release-3.13 March 24, 2025 21:40
@hanwen-cluster hanwen-cluster dismissed their stale review March 24, 2025 21:40

The base branch was changed.

@hanwen-cluster hanwen-cluster marked this pull request as ready for review March 24, 2025 21:40
@hanwen-cluster hanwen-cluster requested review from a team as code owners March 24, 2025 21:40
@hanwen-cluster hanwen-cluster merged commit 50a682f into aws:release-3.13 Mar 24, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants