Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: hacky workaround to not use zlib bundled with SAM CLI In… #142

Merged
merged 5 commits into from
Apr 10, 2024

Conversation

lucashuy
Copy link
Contributor

@lucashuy lucashuy commented Apr 8, 2024

…staller (#141)"

This reverts commit 063b5ce.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lucashuy lucashuy marked this pull request as ready for review April 10, 2024 17:02
@lucashuy lucashuy requested a review from a team as a code owner April 10, 2024 17:02
@lucashuy lucashuy requested review from hawflau and bentvelj April 10, 2024 17:02
@lucashuy
Copy link
Contributor Author

lucashuy commented Apr 10, 2024

The PR checks are failing since the currently released version does not have the zlib fix. The nightly release was used instead (which contains the fix) inside of https://github.com/aws/aws-sam-build-images/actions/runs/8624005122/job/23638252127, which the workflow passes.

This is expected.

@lucashuy lucashuy merged commit 57a1ea9 into aws:develop Apr 10, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants