Bump timeout for this test to 10 seconds to investigate flaky test #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests/end_to_end/test_runtimes_e2e.py::TestHelloWorldZipPackagePermissionsEndToEnd_0_go1_x)
bentvelj
requested review from
mildaniel and
jysheng123
and removed request for
a team
github-actions
bot
added
pr/external
stage/needs-triage
bentvelj
requested review from
lucashuy and
sidhujus
and removed request for
mildaniel and
jysheng123
sidhujus
approved these changes
Jan 22, 2024
lucashuy
reviewed
Jan 22, 2024
| @@ -8,7 +8,7 @@ Description: > | |||
| # More info about Globals: https://github.com/awslabs/serverless-application-model/blob/master/docs/globals.rst | |||
| Globals: | |||
| Function: | |||
| Timeout: 5 | |||
| Timeout: 10 | |||
There was a problem hiding this comment.
I know I had initially mentioned that this should be a relatively safe change, but should we consider duplicating this project on the SAM CLI side, and instead point sam init to that project using the --location flag?
There was a problem hiding this comment.
Yeah, we can do that. Better to minimize the impact
|
Closing in favour of duplicating the project in SAM CLI and changing the template there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sam cli test is timing out on windows occasionally:
tests/end_to_end/test_runtimes_e2e.py::TestHelloWorldZipPackagePermissionsEndToEnd_0_go1_xDescription of changes:
Bumping the timeout as an investigation method to see if this changes the result
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.