Warn for missing BuildArchitecture during Layer build #6355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I've moved the check for
BuildArchitecture
∈CompatibleArchitectures
from PR #6322 (related issue: #6110) into the Layer build, so that it's not exclusive to Makefile Layer builds.To summarize:
BuildArchitecture
is missingBuildArchitecture
is not inCompatibleArchitectures
x86_64
orarm64
)BuildArchitecture
. Other BuildMethods will verify this in LambdaBuilders already, and fail on bad architecture.Which issue(s) does this change fix?
#3747
Why is this change necessary?
Customer is confused as to why the build does not use their
CompatibleArchitectures
when they omitBuildArchitecture
. It has already been decided to default to the case ofx86_64
in the case of missingBuildArchitecture
, so we can warn the customer to add it if it is missing.How does it address the issue?
Adds a warning to Layer builds when
BuildArchitecture
is missing, and thatx86_64
is being used as a default.Also warns if the
BuildArchitecture
specified is not inCompatibleArchitectures
.What side effects does this change have?
N/A
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.