Skip to content

Validate unknown member reference #6177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Jun 12, 2025

Add validation for the case where an endpoint test references a non-existent operation input shape member.

As part of this change, CodeGenerator has ben updated to catch ModelInvalidException and write the validation entries in the validation-report.json.

Motivation and Context

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

Add validation for the case where an endpoint test references a
non-existent operation input shape member.

As part of this change, `CodeGenerator` has ben updated to catch
`ModelInvalidException` and write the validation entries in the
validation-report.json.
@dagnir dagnir force-pushed the dongie/unknown-member-validation branch from 417ebae to bbb9561 Compare June 13, 2025 17:05
@dagnir dagnir marked this pull request as ready for review June 13, 2025 17:09
@dagnir dagnir requested a review from a team as a code owner June 13, 2025 17:09
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@dagnir dagnir merged commit c664392 into feature/master/codegen-validation Jun 13, 2025
17 of 18 checks passed
@dagnir dagnir deleted the dongie/unknown-member-validation branch June 13, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants