[Merge 2nd] Generate AbortMultipartUpload, CreateBucketMetadataTableConfiguration and DeleteBucket related operations. #3870
Conversation
peterrsongg
force-pushed
the
petesong/generate-s3-phase-1-part3
branch
6 times, most recently
from
6ffbc9b to
ec7ff4a
Compare
…od for rest xml marshallers
peterrsongg
force-pushed
the
petesong/generate-s3-phase-1-part3
branch
from
ec7ff4a to
c289d85
Compare
| @@ -736,12 +736,12 @@ | |||
| </None> | |||
| </ItemGroup> | |||
| <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'"> | |||
| <PackageReference Include="Microsoft.CSharp" Version="4.4.1" /> | |||
| <PackageReference Include="Microsoft.CSharp" Version="4.4.1" /> | |||
There was a problem hiding this comment.
this was already here
| @@ -44,11 +44,6 @@ public partial class ListBucketsResponse : AmazonWebServiceResponse | |||
| /// <para> | |||
| /// The list of buckets owned by the requester. | |||
| /// </para> | |||
| /// <para /> | |||
There was a problem hiding this comment.
this won't actually be deleted. Norm's change is in the structuregenerator.cs file. What happened is it was in the tt file but I didnt run the custom tool so when I generated it got deleted. I reran the custom tool to include norm's change so this will remain the same when we actually release.
| @@ -99,12 +117,13 @@ namespace <#=this.Config.Namespace #>.Model.Internal.MarshallTransformations | |||
| ProcessEndpointHostPrefixMembers(3, "publicRequest", this.Operation); | |||
| } | |||
| #> | |||
|
|
|||
| PostMarshallCustomization(request, publicRequest); | |||
There was a problem hiding this comment.
Since 99% of services won't implement this, why not add it only for the marshallers that need it instead of affecting all the xml marshallers?
There was a problem hiding this comment.
Norm and I talked and he wanted this mechanism in here instead of another customization entry which would tell us to generate this for a specific subset.
There was a problem hiding this comment.
Since the other 99% won't implement the partial PostMarshallCustomization the compiler will just compile it away as if it doesn't exists. There is no runtime cost to the other marshallers and I want to avoid as much as possible in the end of this project the number of S3 specific checks we need to do in the generator.
Plus it might be a useful customization point in the future for other services.
Description
This PR generates more S3 operations, but the main addition here is the CustomizeMarshaller partial method that will be generated on every rest-xml request marshaller. 99% of services won't implement this, but for those operations that have some sort of customization, we will create a partial of the marshaller and implement this method. (Discussed with Norm).
Motivation and Context
Testing
Assembly Comparer was run and no breaking changes in non-internal namespaces
DRY_RUN-94321c15-4f1e-4c55-aef9-e9f9c8e1e476
Screenshots (if appropriate)
Types of changes
Checklist
License