Update inject API reference samples to V4 #3878
Merged
+2,017
−2,027
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The custom samples that are injected into the API reference docs were not updated V4. In fact they were so out date they were referencing V2 of the SDK.
I went through and updated the samples project to target .NET 8, use async/await and add null checks.
Motivation and Context
#3869
Testing
Dry Run Success: DRY_RUN-e2890913-0dad-4fef-a554-b1ebd871104d
Download the API docs from Catapult and confirmed the updated samples made it into the docs. Here is the snippet that was called on in the GitHub issue for being out of date to now use async/await and have the null check.