Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add Amazon Q /dev e2e tests #5434

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Conversation

chengoramazon
Copy link
Contributor

@chengoramazon chengoramazon commented Mar 3, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Add Amazon Q /dev e2e tests

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chengoramazon chengoramazon force-pushed the jb-tests branch 4 times, most recently from 868f90d to c10dd0b Compare March 8, 2025 22:35
@chengoramazon
Copy link
Contributor Author

/runUiTests

@chengoramazon
Copy link
Contributor Author

All /dev E2E tests passed.

Failed test case Ensure feature availability on slash()

Retry one more time

@chengoramazon
Copy link
Contributor Author

/runUiTests

@chengoramazon
Copy link
Contributor Author

All /dev E2E tests passed.

Failed test case completion request with expired credentials does not freeze EDT()

Retry one more time

@chengoramazon
Copy link
Contributor Author

/runUiTests

5 similar comments
@chengoramazon
Copy link
Contributor Author

/runUiTests

@chengoramazon
Copy link
Contributor Author

/runUiTests

@chengoramazon
Copy link
Contributor Author

/runUiTests

@chengoramazon
Copy link
Contributor Author

/runUiTests

@chengoramazon
Copy link
Contributor Author

/runUiTests

@chengoramazon chengoramazon requested a review from manodnyab March 10, 2025 15:08
@linyuxi-0511 linyuxi-0511 self-requested a review March 10, 2025 15:50

// Validate if /dev ends the conversation successfully
await page.waitForSelector('p ::-p-text(Okay, I\'ve ended this chat session. You can open a new tab to chat or start another workflow.)', {timeout: 3000});
console.log('Success: /dev ends the conversation successfully.');
Copy link
Contributor

@manodnyab manodnyab Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to catch some of these errors and log them I know the last line does that, but adding it here will provide some more granularity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is not necessary to add error log here as they would mostly just element not found and can be captured in executePuppeteerScript.

@chengoramazon
Copy link
Contributor Author

/runUiTests

@chengoramazon chengoramazon requested a review from manodnyab March 11, 2025 13:38
@chengoramazon
Copy link
Contributor Author

/runUiTests

1 similar comment
@chengoramazon
Copy link
Contributor Author

/runUiTests

@chengoramazon
Copy link
Contributor Author

/runUiTests

@chengoramazon chengoramazon merged commit 85738c3 into aws:main Mar 11, 2025
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants