Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry(amazonq): createUpload metric for scans #5444

Merged
merged 5 commits into from
Mar 8, 2025

Conversation

ctlai95
Copy link
Contributor

@ctlai95 ctlai95 commented Mar 5, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Some users are reporting S3 upload failures but we don't have the requestIds to investigate further.
Emit amazonq_createUpload metric with requestIds

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

import software.aws.toolkits.resources.message
import software.aws.toolkits.telemetry.AmazonqTelemetry

Check warning

Code scanning / QDJVMC

Usage of redundant or deprecated syntax or deprecated symbols Warning

Remove deprecated symbol import
import software.aws.toolkits.resources.message
import software.aws.toolkits.telemetry.AmazonqTelemetry

Check warning

Code scanning / QDJVMC

Usage of redundant or deprecated syntax or deprecated symbols Warning

'AmazonqTelemetry' is deprecated. Use type-safe metric builders
Copy link
Contributor

@laileni-aws laileni-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ctlai95 ctlai95 marked this pull request as ready for review March 5, 2025 17:00
@ctlai95 ctlai95 requested review from a team as code owners March 5, 2025 17:00
throw e
} finally {
if (featureUseCase == CodeWhispererConstants.FeatureName.CODE_REVIEW) {
AmazonqTelemetry.createUpload(

Check warning

Code scanning / QDJVMC

Usage of redundant or deprecated syntax or deprecated symbols Warning

'AmazonqTelemetry' is deprecated. Use type-safe metric builders
@ctlai95 ctlai95 merged commit 246b317 into aws:main Mar 8, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants