Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry(amazonq): Add status field to unit test generation telemetry for tracking user actions #5456

Merged
merged 2 commits into from
Mar 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
import software.aws.toolkits.resources.message
import software.aws.toolkits.telemetry.AmazonqTelemetry
import software.aws.toolkits.telemetry.MetricResult
import software.aws.toolkits.telemetry.Status
import java.io.ByteArrayInputStream
import java.io.ByteArrayOutputStream
import java.io.File
Expand Down Expand Up @@ -158,7 +159,7 @@
throw CodeTestException(
"CreateTestJobError: $errorMessage",
"CreateTestJobError",
message("testgen.error.generic_technical_error_message")

Check warning on line 162 in plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqCodeTest/CodeWhispererUTGChatManager.kt

View workflow job for this annotation

GitHub Actions / qodana

Usage of redundant or deprecated syntax or deprecated symbols

'message(String, vararg Any): String' is deprecated. Use extension-specific localization bundle instead
)
}

Expand Down Expand Up @@ -583,7 +584,8 @@
artifactsUploadDuration = session.artifactUploadDuration,
buildPayloadBytes = session.srcPayloadSize,
buildZipFileBytes = session.srcZipFileSize,
requestId = session.startTestGenerationRequestId
requestId = session.startTestGenerationRequestId,
status = if (e.message == message("testgen.message.cancelled")) Status.CANCELLED else Status.FAILED,
)
session.isGeneratingTests = false
} finally {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ import software.aws.toolkits.telemetry.AmazonqTelemetry
import software.aws.toolkits.telemetry.FeatureId
import software.aws.toolkits.telemetry.InteractionType
import software.aws.toolkits.telemetry.MetricResult
import software.aws.toolkits.telemetry.Status
import software.aws.toolkits.telemetry.UiTelemetry
import java.io.File
import java.nio.file.Files
Expand Down Expand Up @@ -310,7 +311,8 @@ class CodeTestChatController(
credentialStartUrl = getStartUrl(project),
result = MetricResult.Succeeded,
perfClientLatency = (Instant.now().toEpochMilli() - session.startTimeOfTestGeneration),
requestId = id
requestId = id,
status = Status.ACCEPTED,
)
}
session.isGeneratingTests = false
Expand Down Expand Up @@ -682,7 +684,8 @@ class CodeTestChatController(
artifactsUploadDuration = session.artifactUploadDuration,
buildPayloadBytes = session.srcPayloadSize,
buildZipFileBytes = session.srcZipFileSize,
requestId = session.startTestGenerationRequestId
requestId = session.startTestGenerationRequestId,
status = Status.ACCEPTED,
)
codeTestChatHelper.addAnswer(
CodeTestChatMessageContent(
Expand Down Expand Up @@ -878,7 +881,8 @@ class CodeTestChatController(
artifactsUploadDuration = session.artifactUploadDuration,
buildPayloadBytes = session.srcPayloadSize,
buildZipFileBytes = session.srcZipFileSize,
requestId = session.startTestGenerationRequestId
requestId = session.startTestGenerationRequestId,
status = Status.REJECTED,
)
sessionCleanUp(message.tabId)
}
Expand Down
Loading