Version bump, fix tests, remove enableIceStats

Author: niyatim23

CMakeLists.txt

@@ -5,7 +5,7 @@ include(CheckIncludeFiles)
 include(CheckFunctionExists)
 
 # The version MUST be updated before every release
-project(KinesisVideoWebRTCClient VERSION 1.10.1 LANGUAGES C)
+project(KinesisVideoWebRTCClient VERSION 1.10.2 LANGUAGES C)
 
 # User Flags
 option(ADD_MUCLIBC "Add -muclibc c flag" OFF)

samples/CMakeLists.txt

@@ -95,7 +95,7 @@ if(GST_FOUND)
     GstAudioVideoReceiver.c
     kvsWebRTCClientViewerGstSample.c
   )
-  target_link_libraries(kvsWebrtcClientViewerGstSample kvsWebrtcClient kvsWebrtcSignalingClient ${EXTRA_DEPS} ${GST_SAMPLE_LIBRARIES} kvsCommonLws kvspicUtils websockets kvssdp)
+  target_link_libraries(kvsWebrtcClientViewerGstSample kvsWebrtcClient kvsWebrtcSignalingClient ${EXTRA_DEPS} ${GST_SAMPLE_LIBRARIES} kvsCommonLws kvspicUtils websockets)
 
   install(TARGETS kvsWebrtcClientViewerGstSample
     RUNTIME DESTINATION bin

samples/Common.c

@@ -407,7 +407,6 @@ STATUS initializePeerConnection(PSampleConfiguration pSampleConfiguration, PRtcP
     // Set the ICE mode explicitly
     configuration.iceTransportPolicy = ICE_TRANSPORT_POLICY_ALL;
 
-    configuration.kvsRtcConfiguration.enableIceStats = pSampleConfiguration->enableIceStats;
     // Set the  STUN server
     PCHAR pKinesisVideoStunUrlPostFix = KINESIS_VIDEO_STUN_URL_POSTFIX;
     // If region is in CN, add CN region uri postfix
@@ -938,9 +937,6 @@ STATUS createSampleConfiguration(PCHAR channelName, SIGNALING_CHANNEL_ROLE_TYPE
     pSampleConfiguration->pregenerateCertTimerId = MAX_UINT32;
     pSampleConfiguration->signalingClientMetrics.version = SIGNALING_CLIENT_METRICS_CURRENT_VERSION;
 
-    // Flag to enable SDK to calculate selected ice server, local, remote and candidate pair stats.
-    pSampleConfiguration->enableIceStats = FALSE;
-
     // Flag to enable/disable TWCC
     pSampleConfiguration->enableTwcc = TRUE;
 

samples/Samples.h

@@ -176,7 +176,6 @@ typedef struct {
 
     PCHAR rtspUri;
     UINT32 logLevel;
-    BOOL enableIceStats;
     BOOL enableTwcc;
 } SampleConfiguration, *PSampleConfiguration;
 

tst/RtpFunctionalityTest.cpp

@@ -289,7 +289,7 @@ TEST_F(RtpFunctionalityTest, packingUnpackingVerifySameH265Frame)
 
         // First call for payload size and sub payload length size
         EXPECT_EQ(STATUS_SUCCESS,
-                  createPayloadForH265(DEFAULT_MTU_SIZE_BYTES, (PBYTE) payload, payloadLen, NULL, &payloadArray.payloadLength, NULL,
+                  createPayloadForH265(DEFAULT_MTU_SIZE, (PBYTE) payload, payloadLen, NULL, &payloadArray.payloadLength, NULL,
                                        &payloadArray.payloadSubLenSize));
 
         if (payloadArray.payloadLength > payloadArray.maxPayloadLength) {
@@ -309,7 +309,7 @@ TEST_F(RtpFunctionalityTest, packingUnpackingVerifySameH265Frame)
 
         // Second call with actual buffer to fill in data
         EXPECT_EQ(STATUS_SUCCESS,
-                  createPayloadForH265(DEFAULT_MTU_SIZE_BYTES, (PBYTE) payload, payloadLen, payloadArray.payloadBuffer, &payloadArray.payloadLength,
+                  createPayloadForH265(DEFAULT_MTU_SIZE, (PBYTE) payload, payloadLen, payloadArray.payloadBuffer, &payloadArray.payloadLength,
                                        payloadArray.payloadSubLength, &payloadArray.payloadSubLenSize));
 
         EXPECT_LT(0, payloadArray.payloadSubLenSize);

tst/SdpApiTest.cpp

@@ -306,8 +306,6 @@ TEST_F(SdpApiTest, setTransceiverPayloadTypes_HasRtxType_H265)
     transceiver.transceiver.direction = RTC_RTP_TRANSCEIVER_DIRECTION_SENDRECV;
     transceiver.sender.packetBuffer = NULL;
     transceiver.sender.retransmitter = NULL;
-    transceiver.rollingBufferDurationSec = DEFAULT_ROLLING_BUFFER_DURATION_IN_SECONDS;
-    transceiver.rollingBufferBitratebps = DEFAULT_EXPECTED_VIDEO_BIT_RATE;
     EXPECT_EQ(STATUS_SUCCESS, hashTableCreate(&pCodecTable));
     EXPECT_EQ(STATUS_SUCCESS, hashTablePut(pCodecTable, RTC_CODEC_H265, 1));
     EXPECT_EQ(STATUS_SUCCESS, hashTableCreate(&pRtxTable));