-
Notifications
You must be signed in to change notification settings - Fork 343
Cloudwatch integration demo #2013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop-pre-1.11.0
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2013 +/- ##
===========================================
- Coverage 88.68% 88.67% -0.01%
===========================================
Files 48 48
Lines 12726 12726
===========================================
- Hits 11286 11285 -1
- Misses 1440 1441 +1 ☔ View full report in Codecov by Sentry. |
This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one. |
Issue #, if available:
What was changed?
Added a new demo that shows integration with cloudwatch metrics and logs, pushing RTP metrics and some end to end stats with mock frames, along with demonstrating some metrics with storage. The SDK depends on AWS SDK CPP and builds the monitoring and logs component if run with
-DENABLE_AWS_SDK_INTEG=ON
. The demo project uses a config file based mechanism to set the different options in our C SDK. The demo uses the same underlying common.c and other common wrappers that our samples use todayRearranged Common.c into different files to add more clarity to the basic building blocks of the existing samples
Created a new MetricsHandling object that handles RTP stats calculation. ICE stats are still out of this and treated separately to avoid potential breaking in customer application.
Why was it changed?
How was it changed?
-DCW_CONFIG_HEADER
optionsetUpCredentialProvider
to set up IoT/long term credential provider. This is a mandatory requirement if using the samples provided with the next release - this change was made since this set up was masked behind a #ifdef block which would require sample modification, this is not conducive for the demo specifically if these decisions are taken based on a config file or even environment variable.What testing was done for the changes?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.