Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual-Stack Endpoints Support #2104

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
Draft

Dual-Stack Endpoints Support #2104

wants to merge 11 commits into from

Conversation

stefankiesz
Copy link
Contributor

@stefankiesz stefankiesz commented Mar 13, 2025

Issue #, if available:
N/A

What was changed?

  • Added support for sample applications to be able to specify to use dual-stack endpoints for KVS.
    • This will allow applications to opt-in to using dual-stack (IPv4 & IPv6-supported) endpoints while leaving the legacy (IPv4-only) endpoints to be the default mode.
  • The Common.c sample file now demonstrates how to generate a dual-stack Control Plane endpoint based on the configured region.
  • Gathered the createSampleConfiguration function's parameters, including the new useDualStackEndpoints parameter, into a single struct to avoid excessively long function signature.

Note

The name for this new useDualStackEndpoints parameter is plural because using the dual-stack Control Plane endpoint (once it is ready) will result in a dual-stack signaling channel server endpoint which will result in dual-stack TURN server URIs. It also will likely control legacy/dual-stack of the KVS STUN server endpoint that is also constructed in the application.

Why was it changed?

  • For testing and demonstrating dual-stack endpoints.

How was it changed?

  • By adding the relevant parameter and moving MAX_CONTROL_PLANE_URI_CHAR_LEN into a public header file for the application to access it.

What testing was done for the changes?

  • Added unit tests to ensure that passed-in custom endpoints get set when constructing and validating ClientInfo object.
  • Will add CI tests configured to use the dual-stack endpoints once they are ready.
  • These code changes only work with public endpoints; have not tested with the public endpoints yet because they are not yet ready.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@stefankiesz
Copy link
Contributor Author

Important

Remember to revert Producer C SDK tag before merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants