Skip to content

Updated .h265 frames and improved the looping logic #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Varunaditya1
Copy link

Issue #, if available:
The Viewer JS pages stops at 09.960 timestamp frame.

What was changed?
All the .h265 frames are modified along with the Macro of NUMBER_OF_H265_FRAME_FILES, along with the logic of looping among the frames.

Why was it changed?
The Viewer JS pages stops at 09.960 timestamp frame.

How was it changed?
The frames were re-generated using ffmpeg.

What testing was done for the changes?

Yes tested the changes multiple times and on multiple devices.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@unicornss unicornss self-assigned this Apr 4, 2025
@sirknightj
Copy link
Contributor

Hi @Varunaditya1, thanks for the contribution.

As discussed offline, we've proceeded with #2111 for the frames adjustment. We'd still like to get your fix for the corrected constant being used for the H.265 path. Could you adjust the PR and also target develop branch. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants