Skip to content

Add basic Credentials wrapper + ManagedNative mixin #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 12, 2020
Merged

Conversation

alextwoods
Copy link
Contributor

@alextwoods alextwoods commented Sep 28, 2020

Description of changes:

  • Add a basic Credentials object that wraps CRT Credentials and conforms to the Aws::Credentials interface.
  • Add ManagedNative mixin for classes that manage/wrap a native object.
  • Add ByteCursor struct for outputs instead of :string.
  • Extend FFI attach_function in our module to provide: 1) error wrapping (with an "unsafe" ! version of the method that does not do error checking) and 2) handle renaming methods in ruby to remove the aws_crt_ prefix. This replaces the Aws::Crt::call method completely!

Note: TruffleRuby currently has an FFI bug - they do not support Struct.by_value. I've +1 and commented on their issue: oracle/truffleruby#2069 but for now am dropping truffleruby from the CI :-(

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@graebm graebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed Credentials

@alextwoods alextwoods changed the title [WIP] Add basic Credentials wrapper + Sigv base interface [WIP] Add basic Credentials wrapper + ManagedNative mixin Sep 30, 2020
@alextwoods alextwoods marked this pull request as ready for review October 1, 2020 16:42
@graebm graebm changed the title [WIP] Add basic Credentials wrapper + ManagedNative mixin Add basic Credentials wrapper + ManagedNative mixin Oct 7, 2020
@alextwoods alextwoods merged commit 10311e1 into master Oct 12, 2020
@alextwoods alextwoods deleted the signer branch October 12, 2020 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants