refactor: replace FakeClientBuilder with spy #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markjschreiber
deleted the
markjschreiber/refactor/remove-fakeclientbuilder
branch
stefanofornari
added a commit
to stefanofornari/aws-java-nio-spi-for-s3
that referenced
this pull request
Feb 14, 2024
stefanofornari
pushed a commit
to stefanofornari/aws-java-nio-spi-for-s3
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Removes the FakeClientBuilder and replaces it's usage in tests with a Spy. The motivation for the removal is that updates to the AWS S3 SDK frequently add method calls to the builder class with the fake class must implement, but offer no value to our tests. Using a spy adds a little complexity but hopefully makes it easier to frequently update our SDK build.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.