fix for #293 #394
Merged
fix for #293 #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/java/nio/file/Path.html#subpath-int-int- subpath shall return a relative path
| @@ -257,10 +257,6 @@ public S3Path subpath(int beginIndex, int endIndex) { | |||
| } | |||
|
|
|||
| var path = String.join(PATH_SEPARATOR, pathRepresentation.elements().subList(beginIndex, endIndex)); | |||
There was a problem hiding this comment.
path can probably be final
markjschreiber
approved these changes
Mar 4, 2024
stefanofornari
added a commit
to stefanofornari/aws-java-nio-spi-for-s3
that referenced
this pull request
May 20, 2024
…/java/nio/file/Path.html#subpath-int-int- subpath shall return a relative path (awslabs#394)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#293
Description of changes:
The current implementation violates the intended behaviour or relativize when relativizing a path to the root. The correct behaviour should be like:
Side note: the use of var is particularly disappointing in
S3Pathwhere it should be clear if an object is aPathor aS3PathBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.