-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable random access when opening a SeekableByteChannel
or FileChannel
#618
Conversation
Thanks for this contribution. It looks like the CI check failed during integration testing with:
Can you take a look? Let me know if you need help. |
The test failures are caused by missing AWS credentials while either downloading or uploading the temporary file. I wonder why, because the test setup works. I'm surprised that the test cases in |
@markjschreiber I found the problem and fixed it. Please have a look at line 838 to 840 in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you saw the comment on adding usnit tests for the new methods in S3WritableByteChannel
? With those I believe we can merge this PR.
Updating this PR to merge in other changes. Hopefully this will make it easier to merge when you add unit tests |
- Get size from write channel instead of fetching - This is a workaround for the case where the file does not exist remotely but the caller is working with the open option `CREATE`. - Add unit tests
I've added the unit tests as requested. Let me know if it needs some changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition! Thanks.
Description of changes:
READ
andWRITE
support when opening aSeekableByteChannel
(orFileChannel
).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.