Transport system properties to S3 NIO configuration #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@markjschreiber what do you think about this change? |
|
Thanks for catching that. Can you also add a unit test so we don't regress here? |
|
It also seems like checkstyle has an issue with the constructor? https://github.com/awslabs/aws-java-nio-spi-for-s3/actions/runs/13662494792/job/38197409194?pr=635 |
|
@markjschreiber I double-checked the implementation with tests and it seems to work as expected, therefore I close the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to documentation the endpoint protocol can be configured via system properties, which is not working at the moment. This change makes this possible.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.