Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport system properties to S3 NIO configuration #635

Closed
wants to merge 2 commits into from
Closed

Transport system properties to S3 NIO configuration #635

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79ea9a7
Transport system properties to S3 NIO configuration
arouel Feb 22, 2025
bd9d1be
Merge branch 'main' into sys-prop-to-config
markjschreiber Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/main/java/software/amazon/nio/spi/s3/config/S3NioSpiConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,18 @@ public class S3NioSpiConfiguration extends HashMap<String, Object> {
* Create a new, empty configuration
*/
public S3NioSpiConfiguration() {
this(new HashMap<>());
this(systemProperties());
}

private static Map<String, ?> systemProperties() {
var map = new HashMap<String, Object>();
var properties = System.getProperties();
for (var name : properties.stringPropertyNames()) {
if (name.startsWith("aws.") || name.startsWith("s3.")) {
map.put(name, properties.getProperty(name));
}
}
return map;
}

/**
Expand Down