Use a temporary directory per file system and preserve the directory structure locally #641
+105
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arouel
force-pushed
the
temp-dir-per-file-system
branch
2 times, most recently
from
7b875cb to
1344465
Compare
Use a temporary directory per file system and preserve the directory structure locally as it is remote.
arouel
force-pushed
the
temp-dir-per-file-system
branch
from
1344465 to
9086e82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to better understand which file I'm messing around with while debugging locally, I find it really helpful when the directory structure is preserved as it exists on S3. Therefore, I suggest to have a temporary directory per
S3FileSysteminstance and locally cached S3 files are mirrored there with their key in correspondence to the bucket location.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.