Skip to content

Commit

Permalink
CI: Fix ROCm 6.2.0
Browse files Browse the repository at this point in the history
ROCm 6.1.2->6.2.0 switches Clang 17 to 18.
The current setup led to linker issues:
```
ld.lld: error: undefined hidden symbol: __hip_gpubin_handle_f20551e8c5453d2a
>>> referenced by ld-temp.o
>>>               lto.tmp:(__hip_module_ctor.1796)
>>> referenced by ld-temp.o
>>>               lto.tmp:(__hip_module_ctor.1796)
>>> referenced by ld-temp.o
>>>               lto.tmp:(__hip_module_dtor.1798)
>>> referenced 1 more times
```

switch from clang++ to hipcc as the compiler.
  • Loading branch information
ax3l committed Aug 6, 2024
1 parent 1eff1df commit 31df7e7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/dependencies/hip.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash
#
# Copyright 2022 The ImpactX Community
# Copyright 2022 The AMReX Community
#
# License: BSD-3-Clause-LBNL
# Authors: Axel Huebl
Expand Down Expand Up @@ -32,6 +32,7 @@ echo "deb [arch=amd64] https://repo.radeon.com/rocm/apt/${1-latest} ${UBUNTU_COD
| sudo tee /etc/apt/sources.list.d/rocm.list
echo 'export PATH=/opt/rocm/llvm/bin:/opt/rocm/bin:/opt/rocm/profiler/bin:/opt/rocm/opencl/bin:$PATH' \
| sudo tee -a /etc/profile.d/rocm.sh

# we should not need to export HIP_PATH=/opt/rocm/hip with those installs

sudo apt-get update
Expand Down Expand Up @@ -65,3 +66,4 @@ which clang++
sudo curl -L -o /usr/local/bin/cmake-easyinstall https://raw.githubusercontent.com/ax3l/cmake-easyinstall/main/cmake-easyinstall
sudo chmod a+x /usr/local/bin/cmake-easyinstall
export CEI_SUDO="sudo"
export CEI_TMP="/tmp/cei"
2 changes: 1 addition & 1 deletion .github/workflows/hip.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
hipcc --version
which clang
which clang++
export CXX=$(which clang++)
export CXX=$(which hipcc)
export CC=$(which clang)
python3 -m pip install -U pip importlib_metadata launchpadlib setuptools wheel
Expand Down

0 comments on commit 31df7e7

Please sign in to comment.