From 31df7e7e5f73fb4ce9087e0fdd11257039d6a0e7 Mon Sep 17 00:00:00 2001 From: Axel Huebl Date: Tue, 6 Aug 2024 14:50:18 -0700 Subject: [PATCH] CI: Fix ROCm 6.2.0 ROCm 6.1.2->6.2.0 switches Clang 17 to 18. The current setup led to linker issues: ``` ld.lld: error: undefined hidden symbol: __hip_gpubin_handle_f20551e8c5453d2a >>> referenced by ld-temp.o >>> lto.tmp:(__hip_module_ctor.1796) >>> referenced by ld-temp.o >>> lto.tmp:(__hip_module_ctor.1796) >>> referenced by ld-temp.o >>> lto.tmp:(__hip_module_dtor.1798) >>> referenced 1 more times ``` switch from clang++ to hipcc as the compiler. --- .github/workflows/dependencies/hip.sh | 4 +++- .github/workflows/hip.yml | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/dependencies/hip.sh b/.github/workflows/dependencies/hip.sh index ce0de7c2..3b5299ac 100755 --- a/.github/workflows/dependencies/hip.sh +++ b/.github/workflows/dependencies/hip.sh @@ -1,6 +1,6 @@ #!/usr/bin/env bash # -# Copyright 2022 The ImpactX Community +# Copyright 2022 The AMReX Community # # License: BSD-3-Clause-LBNL # Authors: Axel Huebl @@ -32,6 +32,7 @@ echo "deb [arch=amd64] https://repo.radeon.com/rocm/apt/${1-latest} ${UBUNTU_COD | sudo tee /etc/apt/sources.list.d/rocm.list echo 'export PATH=/opt/rocm/llvm/bin:/opt/rocm/bin:/opt/rocm/profiler/bin:/opt/rocm/opencl/bin:$PATH' \ | sudo tee -a /etc/profile.d/rocm.sh + # we should not need to export HIP_PATH=/opt/rocm/hip with those installs sudo apt-get update @@ -65,3 +66,4 @@ which clang++ sudo curl -L -o /usr/local/bin/cmake-easyinstall https://raw.githubusercontent.com/ax3l/cmake-easyinstall/main/cmake-easyinstall sudo chmod a+x /usr/local/bin/cmake-easyinstall export CEI_SUDO="sudo" +export CEI_TMP="/tmp/cei" diff --git a/.github/workflows/hip.yml b/.github/workflows/hip.yml index 8efb2102..d4d83709 100644 --- a/.github/workflows/hip.yml +++ b/.github/workflows/hip.yml @@ -39,7 +39,7 @@ jobs: hipcc --version which clang which clang++ - export CXX=$(which clang++) + export CXX=$(which hipcc) export CC=$(which clang) python3 -m pip install -U pip importlib_metadata launchpadlib setuptools wheel