[patch-axel-11b] MyPi native #155
Draft
+489
−1,048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axel-h
force-pushed
the
patch-axel-11b
branch
29 times, most recently
from
3a687e1 to
955f6c9
Compare
Signed-off-by: Axel Heider <axelheider@gmx.de>
Signed-off-by: Axel Heider <axelheider@gmx.de>
Removing the function because it is not use anywhere. Not cloning the owner seems an inconsistent behavior anyway. Signed-off-by: Axel Heider <axelheider@gmx.de>
Support comparisson operations for derived objects only, and fail for anything else. Currently there is no use case that requires duck typing and stricter type checking allows catching potential errors. Signed-off-by: Axel Heider <axelheider@gmx.de>
Signed-off-by: Axel Heider <axelheider@gmx.de>
Signed-off-by: Axel Heider <axelheider@gmx.de>
The DTB appears broken if an item in the chosen node can't be resolved. Raise an error instead of silently ignoring this, as it might be a typo that must be fixed. Otherwise, non-existing items should be removed from the chosen node in a overlay file. Signed-off-by: Axel Heider <axelheider@gmx.de>
The return values is not used by any known callers of this function. There is no sane generic way to handle return values on recursive invocations, thus any visitor must handle this internally. This is doable in Python easily, so there is no need for an additional explicit context parameter either. Signed-off-by: Axel Heider <axelheider@gmx.de>
Element 0 may not exist if the string is empty. Signed-off-by: Axel Heider <axelheider@gmx.de>
Lists are ordered and enumerate() provides the index. Signed-off-by: Axel Heider <axelheider@gmx.de>
Also raise exception is there are no regions at all. Signed-off-by: Axel Heider <axelheider@gmx.de>
Signed-off-by: Axel Heider <axelheider@gmx.de>
Signed-off-by: Axel Heider <axelheider@gmx.de>
Signed-off-by: Axel Heider <axelheider@gmx.de>
Even if NotImplemented is of the type NotImplementedType technically, it is not supposed to be mentioned explicitly in the return types. Signed-off-by: Axel Heider <axelheider@gmx.de>
'Callable' was added in Python 3.6 in 'collections.abc'. Signed-off-by: Axel Heider <axelheider@gmx.de>
Signed-off-by: Axel Heider <axelheider@gmx.de>
Signed-off-by: Axel Heider <axelheider@gmx.de>
Signed-off-by: Axel Heider <axelheider@gmx.de>
In Python 3.8 the self-references are also supported natively. Signed-off-by: Axel Heider <axelheider@gmx.de>
Signed-off-by: Axel Heider <axelheider@gmx.de>
Signed-off-by: Axel Heider <axelheider@gmx.de>
Signed-off-by: Axel Heider <axelheider@gmx.de>
Signed-off-by: Axel Heider <axelheider@gmx.de>
Use commit af80858 of github.com/dabeaz/ply/src/ply/lex.py Signed-off-by: Axel Heider <axelheider@gmx.de>
"annotations" exists in __future__ since 3.7.0b1 and was planned to become mandatory in 3.10. But this has been postponed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.