need to add back drop_last for sampler (#1676)

axolotl-ai-cloud · May 31, 2024 · 05b0bd0 · 05b0bd0
1 parent d4f6c65
commit 05b0bd0
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/axolotl/core/trainer_builder.py b/src/axolotl/core/trainer_builder.py
@@ -384,6 +384,7 @@ def _get_train_sampler(self) -> Optional[torch.utils.data.Sampler]:
                 batch_size=batch_size,
                 group_size=self.args.sample_packing_group_size,
                 bin_size=self.args.sample_packing_bin_size,
+                drop_last=True,
             )
         if self.args.curriculum_sampling:
             return SequentialSampler(self.train_dataset)
@@ -408,6 +409,7 @@ def _get_eval_sampler(
                 batch_size=batch_size,
                 group_size=self.args.sample_packing_group_size,
                 bin_size=self.args.sample_packing_bin_size,
+                drop_last=True,
             )
         return super()._get_eval_sampler(eval_dataset)