Skip to content

Commit

Permalink
don't install extraneous old version of pydantic in ci and make sre t…
Browse files Browse the repository at this point in the history
…o run multigpu ci (#2355)
  • Loading branch information
winglian authored Feb 22, 2025
1 parent bf84273 commit a417003
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 11 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/multi-gpu-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ on:
pull_request:
paths:
- 'tests/e2e/multigpu/*.py'
- 'requirements.txt'
- 'setup.py'
- 'pyproject.toml'
- '.github/workflows/multi-gpu-e2e.yml'
workflow_dispatch:
schedule:
- cron: '0 0 * * 1,4' # Runs at 00:00 UTC every monday & thursday
Expand Down
14 changes: 5 additions & 9 deletions cicd/multigpu.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,11 @@
with open(pathlib.Path(temp_dir) / "Dockerfile", "w", encoding="utf-8") as f:
f.write(dockerfile_contents)

cicd_image = (
Image.from_dockerfile(
pathlib.Path(temp_dir) / "Dockerfile",
force_build=True,
gpu="A10G",
)
.env(df_args)
.pip_install("fastapi==0.110.0", "pydantic==2.6.3")
)
cicd_image = Image.from_dockerfile(
pathlib.Path(temp_dir) / "Dockerfile",
force_build=True,
gpu="A10G",
).env(df_args)

app = App("Axolotl CI/CD", secrets=[])

Expand Down
2 changes: 0 additions & 2 deletions src/axolotl/cli/cloud/modal_.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,6 @@ def get_image(self):
if env := self.get_env():
image = image.env(env)

image = image.pip_install("fastapi==0.110.0", "pydantic==2.6.3")

return image

def get_secrets(self):
Expand Down

0 comments on commit a417003

Please sign in to comment.