Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing torch 2.3.1 #2294

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Removing torch 2.3.1 #2294

merged 1 commit into from
Jan 29, 2025

Conversation

SalmanMohammadi
Copy link
Contributor

Description

Motivation and Context

How has this been tested?

Screenshots (if appropriate)

Types of changes

Social Handles (Optional)

@SalmanMohammadi SalmanMohammadi marked this pull request as ready for review January 28, 2025 20:46
@winglian winglian merged commit c071a53 into main Jan 29, 2025
11 checks passed
@winglian winglian deleted the remove_torch_2_3 branch January 29, 2025 04:23
@djsaunde
Copy link
Contributor

Out of curiosity, what was the impetus for this?

@SalmanMohammadi
Copy link
Contributor Author

SalmanMohammadi commented Jan 29, 2025

Out of curiosity, what was the impetus for this?

CI was failing on 2.3.1 with fused=True torch AdamW https://github.com/axolotl-ai-cloud/axolotl/actions/runs/13014783778/job/36301130570?pr=2293

Also it significantly simplifies our setup process as we don't have to wrangle other dependencies which generally require more up-to-date versions of torch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants