Skip to content

πŸ›‘οΈ Potential slashing evasion during re-delegation #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ccamel opened this issue May 15, 2024 · 2 comments
Closed

πŸ›‘οΈ Potential slashing evasion during re-delegation #619

ccamel opened this issue May 15, 2024 · 2 comments
Assignees
Labels
security audit Categorizes an issue or PR as relevant to Security Audit

Comments

@ccamel
Copy link
Member

ccamel commented May 15, 2024

Note

Severity: High
target: v7.1.0 - Commit: 3c854270b006db30aa3894da2cdba10cc31b8c5f
Ref: OKP4 Blockchain Audit Report v1.0 - 02-05-2024 - BlockApex

Description

During our review of the okp4d (now axoned) blockchain, a significant vulnerability was detected in the staking module of the cosmos-sdk version v0.50.4, which is currently deployed in okp4d. This critical flaw is associated with the possibility of slashing evasion during re-delegation events. As detailed in the security advisory, the vulnerability stems from a flaw in the slashing mechanism which could potentially allow delegations involved in byzantine behavior to evade slashing penalties if the validator has not yet been slashed and is subjected to re-delegation. This issue was identified and rectified in the subsequent cosmos-sdk release (v0.50.5).

To thoroughly assess the severity and real-time implications of this vulnerability on the okp4d blockchain, we executed internal tests using the test case scenarios available in the okp4d repository. Our findings confirm that the vulnerability is indeed exploitable under the current configuration, which underscores the importance of swiftly updating the blockchain dependencies to safeguard against such potential exploits.

Recommandation

To mitigate this risk, we recommend that okp4d promptly upgrade to cosmos-sdk v0.50.5.

References

@ccamel ccamel added the security audit Categorizes an issue or PR as relevant to Security Audit label May 15, 2024
@github-project-automation github-project-automation bot moved this to πŸ“‹ Backlog in πŸ’» Development May 15, 2024
@ccamel ccamel moved this from πŸ“‹ Backlog to πŸ“† To do in πŸ’» Development May 15, 2024
@github-project-automation github-project-automation bot moved this to πŸ“‹ Backlog in πŸ’» Development May 15, 2024
@ccamel ccamel moved this from πŸ“‹ Backlog to πŸ“† To do in πŸ’» Development May 15, 2024
@bdeneux
Copy link
Contributor

bdeneux commented May 21, 2024

cosmos-sdk has been updated to v0.50.6. See #642

@ccamel ccamel moved this from πŸ“† To do to πŸ§ͺ To test in πŸ’» Development May 22, 2024
@amimart
Copy link
Member

amimart commented Jun 4, 2024

cosmos-sdk has been updated to v0.50.6. See #642

All good :)

@amimart amimart closed this as completed Jun 4, 2024
@github-project-automation github-project-automation bot moved this from πŸ“† To do to βœ… Done in πŸ’» Development Jun 4, 2024
@github-project-automation github-project-automation bot moved this from πŸ§ͺ To test to βœ… Done in πŸ’» Development Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security audit Categorizes an issue or PR as relevant to Security Audit
Projects
Status: βœ… Done
Development

No branches or pull requests

3 participants