Skip to content

🔐 Add ability to choose proofPurpose on sign VC #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bdeneux opened this issue Aug 19, 2024 · 2 comments · Fixed by #727
Closed

🔐 Add ability to choose proofPurpose on sign VC #724

bdeneux opened this issue Aug 19, 2024 · 2 comments · Fixed by #727
Assignees

Comments

@bdeneux
Copy link
Contributor

bdeneux commented Aug 19, 2024

📝 Purpose

Following this discussion, when signing a Verifiable Credential (VC) through the CLI command axoned credential sign <vc.jsonld>, we need to add the possibility to choose the proofPurpose field value instead of the default one currently set (assertionMethod).

👩‍💻 Solution

I am seeking clarification on whether the possible values for the proofPurpose field are limited to those listed in the W3C specification or if it can accept any string value.

To implement this feature, we will add a command flag --purpose to the sign command. If the possible values for proofPurpose are limited, we will validate the input against the allowed values. If the field can accept any string, we will allow any input. The logic for adding the signature with the specified purpose should be implemented here: sign.go#L262-L276.

🔗 Related links

@bdeneux
Copy link
Contributor Author

bdeneux commented Aug 19, 2024

@amimart @ccamel Is this proposed solution sounds good to you ? Any other idea ?

Linked issue that need this feature : axone-protocol/axone-sdk#11

@amimart
Copy link
Member

amimart commented Aug 19, 2024

@amimart @ccamel Is this proposed solution sounds good to you ? Any other idea ?

Sounds good to me, regarding the possible values I don't have a strong opinion, allow to enter an arbitrary string seems ok to me

@bdeneux bdeneux self-assigned this Aug 19, 2024
@bdeneux bdeneux linked a pull request Aug 19, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in 💻 Development Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants