build(project): add fallback for color handling when tput is unavailable #831
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes in this pull request focus on the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Makefile
participant tput
User->>Makefile: Request color output
Makefile->>tput: Execute tput command for color
alt tput supported
tput-->>Makefile: Return color code
else tput unsupported
tput-->>Makefile: Return error
Makefile-->>User: Output empty string
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
Makefile (1)
29-35: LGTM! Consider refactoring for improved maintainability.The implementation correctly handles environments where
tputis unavailable by adding fallback to empty string. However, the code could be more maintainable.Consider consolidating the common parts into a helper function:
-# Some colors (if supported) -COLOR_GREEN = $(shell tput -Txterm setaf 2 2>/dev/null || echo "") -COLOR_YELLOW = $(shell tput -Txterm setaf 3 2>/dev/null || echo "") -COLOR_WHITE = $(shell tput -Txterm setaf 7 2>/dev/null || echo "") -COLOR_CYAN = $(shell tput -Txterm setaf 6 2>/dev/null || echo "") -COLOR_RED = $(shell tput -Txterm setaf 1 2>/dev/null || echo "") -COLOR_RESET = $(shell tput -Txterm sgr0 2>/dev/null || echo "") +# Helper function to get color codes with fallback +define get_color +$(shell tput -Txterm $(1) $(2) 2>/dev/null || echo "") +endef + +# Some colors (if supported) +COLOR_GREEN = $(call get_color,setaf,2) +COLOR_YELLOW = $(call get_color,setaf,3) +COLOR_WHITE = $(call get_color,setaf,7) +COLOR_CYAN = $(call get_color,setaf,6) +COLOR_RED = $(call get_color,setaf,1) +COLOR_RESET = $(call get_color,sgr0,)This refactoring:
- Reduces code duplication
- Centralizes the fallback logic
- Makes it easier to maintain and modify the color handling
ccamel
force-pushed
the
build/makefile-colors
branch
from
5fefaba to
08542bf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #831 +/- ##
=======================================
Coverage 45.03% 45.03%
=======================================
Files 113 113
Lines 6395 6395
=======================================
Hits 2880 2880
Misses 3380 3380
Partials 135 135 |
Gracefully handle environments where tput is unavailable.
Summary by CodeRabbit
tputcommands.