chore(logic): register internal predicate wrappers instead of engine ones

[ccamel]

Self explanatory.

Summary by CodeRabbit

• Refactor
  • Streamlined core operation mappings to enhance overall consistency and reliability in functionality.

[coderabbitai]

Walkthrough

The changes update the value mappings for four predicates within the registry in x/logic/interpreter/registry.go. The mappings for asserta/1, assertz/1, retract/1, and abolish/1 have been modified to reference implementations from the predicate package instead of the engine package. The registry structure and predicate keys remain unchanged.

Changes

File	Change Summary
x/logic/.../registry.go	Updated predicate mappings for asserta/1, assertz/1, retract/1, and abolish/1 from using engine package methods to using predicate package methods.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Registry
    participant Predicate
    Client->>Registry: Lookup and execute "asserta/1"
    Registry->>Predicate: Invoke predicate.Asserta
    Predicate-->>Registry: Return result
    Registry-->>Client: Provide result

Loading

Possibly related PRs

• Feat/more predicates #783: Updates similar predicate mappings in the registry, aligning with the changes made here.
• Feat/expose database predicates #812: Introduces new tests for predicate functions, directly relating to the updated mappings.

Suggested reviewers

• bdeneux
• amimart

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2
Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 72a47d8 and bfbb02e.

📒 Files selected for processing (1)

• x/logic/interpreter/registry.go (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.go`: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.

**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.

• x/logic/interpreter/registry.go

🧬 Code Definitions (1)

x/logic/interpreter/registry.go (1)

x/logic/predicate/database.go (4)

• Asserta (13-15)
• Assertz (25-27)
• Retract (37-39)
• Abolish (50-52)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: test-go
• GitHub Check: build-docker
• GitHub Check: analyze-go
• GitHub Check: lint-generated
• GitHub Check: lint-go

🔇 Additional comments (1)

x/logic/interpreter/registry.go (1)

47-50: Appropriate architectural shift to internal predicate wrappers

The change from direct engine predicates to predicate package wrappers aligns with the architectural pattern observed elsewhere in this file. Many other predicates (like CurrentOutput, Open, etc.) are already using the predicate package implementations.

This modification improves the code's architectural consistency and provides better encapsulation. By using internal wrappers, the codebase gains flexibility to modify these predicates in the future without directly changing the engine implementation.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #923      +/-   ##
==========================================
+ Coverage   38.49%   38.58%   +0.09%     
==========================================
  Files         113      113              
  Lines        6476     6476              
==========================================
+ Hits         2493     2499       +6     
+ Misses       3863     3857       -6     
  Partials      120      120              

Files with missing lines	Coverage Δ
x/logic/interpreter/registry.go	0.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.