di: add safe wrapper around LLVMGlobalCopyAllMetadata #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandrod
force-pushed
the
di-metadata-entries
branch
4 times, most recently
from
3a389c3 to
1119ca7
Compare
vadorovsky
requested changes
Jan 14, 2024
| LLVMValueMetadataEntriesGetMetadata(entries, index as u32), | ||
| ) | ||
| }) | ||
| struct MetadataEntries { |
There was a problem hiding this comment.
Can we move it to src/llvm/types/di.rs?
There was a problem hiding this comment.
Not all metadata is DI?
There was a problem hiding this comment.
True. I see that the LLVMGlobalCopyAllMetadata belongs to llvm/lib/IR/Core.cpp. I would then keep it in src/llvm/types/ir.rs (or, eventually, but probably too muc effort - split ir.rs into a subdir with mod.rs and core.rs, where eventual wrappers for other IR/* files could have their own files).
My main point is that I would prefer to not mix wrappers (which are currently in the types subdir) and DI sanitization logic in the same module.
Add MetadataEntries which is a safe wrapper around LLVMGlobalCopyAllMetadata. Before this change we used to leak the returned entries.
alessandrod
force-pushed
the
di-metadata-entries
branch
from
1119ca7 to
581ed84
Compare
|
Closed as part of #173 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MetadataEntries which is a safe wrapper around LLVMGlobalCopyAllMetadata. Before this change we used to leak the returned entries.