chore: Update to LLVM 20 #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... I'm not sure if linking llvm-sys 191.x to LLVM 20 will work. If yes, that's great. If not, we need to bump the LLVM version in llvm-sys first. I've already started preparing that change, I'm planning to make a PR next morning. |
vadorovsky
approved these changes
Feb 18, 2025
|
Hum, interesting - the failing tests have just some mismatch in the DI/IR, but overall linking to LLVM 20 seems to work just fine. On a side note, I opened a PR in llvm-sys. |
tamird
force-pushed
the
llvm-20
branch
2 times, most recently
from
8debd49 to
2f13419
Compare
Latest Rust nightly switched to LLVM 20, so we need to update in order to support rustc-llvm-proxy.
|
@vadorovsky I don't have a Linux machine handy to test on. Could you see if you can find out why the DI is lacking this function? |
Sure, I will take care of that |
The previous code, which wasn't making any use of the return value of `my_function`, was optimized out after upgrading to LLVM 20. Using the return value prevents that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is