Skip to content

Commit

Permalink
Merge pull request #1720 from aziontech/UXE-4928-tracker-event-failed…
Browse files Browse the repository at this point in the history
…-create-uder-and-edit

[UXE-4928] feat: add failed create user and edit tracker event
  • Loading branch information
pauloSF0 authored Sep 18, 2024
2 parents db506cf + 31797e9 commit 81fd322
Show file tree
Hide file tree
Showing 5 changed files with 30 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export const makeEdgeApplicationErrorResponsesBaseUrl = () => {
const version = 'v4'
return `${version}/edge/applications`
return `${version}/edge_application/applications`
}
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ describe('EdgeApplicationErrorResponsesServices', () => {
const errorResponse = fixtures.errorResponsePayload.errorResponses[0]

expect(requestSpy).toHaveBeenCalledWith({
url: `v4/edge/applications/${fixtures.errorResponsePayload.edgeApplicationId}/error_responses/${fixtures.errorResponsePayload.id}`,
url: `v4/edge_application/applications/${fixtures.errorResponsePayload.edgeApplicationId}/error_responses/${fixtures.errorResponsePayload.id}`,
method: 'PATCH',
body: {
error_responses: [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ describe('EdgeApplicationErrorResponsesServices', () => {
await sut({ edgeApplicationId: edgeApplicationId })

expect(requestSpy).toHaveBeenCalledWith({
url: `v4/edge/applications/${edgeApplicationId}/error_responses`,
url: `v4/edge_application/applications/${edgeApplicationId}/error_responses`,
method: 'GET'
})
})
Expand Down
13 changes: 13 additions & 0 deletions src/views/Users/CreateView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
@on-response="handleResponse"
:createService="props.createUsersService"
:schema="validationSchema"
@on-response-fail="handleTrackFailedCreation"
>
<template #form="{ resetForm }">
<FormFieldsUsers
Expand Down Expand Up @@ -41,6 +42,7 @@
import FormFieldsUsers from './FormsFields/FormFieldsUsers.vue'
import ActionBarTemplate from '@/templates/action-bar-block/action-bar-with-teleport'
import { inject } from 'vue'
import { handleTrackerError } from '@/utils/errorHandlingTracker'
/**@type {import('@/plugins/analytics/AnalyticsTrackerAdapter').AnalyticsTrackerAdapter} */
const tracker = inject('tracker')
Expand Down Expand Up @@ -87,6 +89,17 @@
twoFactorEnabled: yup.boolean()
})
const handleTrackFailedCreation = (error) => {
const { fieldName, message } = handleTrackerError(error)
tracker.product
.failedToCreate({
productName: 'User',
errorType: 'api',
fieldName: fieldName.trim(),
errorMessage: message
})
.track()
}
const handleResponse = () => {
tracker.product.productCreated({
productName: 'User'
Expand Down
14 changes: 14 additions & 0 deletions src/views/Users/EditView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import { useToast } from 'primevue/usetoast'
import { ref, inject } from 'vue'
import { useRoute } from 'vue-router'
import { handleTrackerError } from '@/utils/errorHandlingTracker'
/**@type {import('@/plugins/analytics/AnalyticsTrackerAdapter').AnalyticsTrackerAdapter} */
const tracker = inject('tracker')
Expand Down Expand Up @@ -61,6 +62,18 @@
const currentEmail = ref()
const handleTrackFailedEdit = (error) => {
const { fieldName, message } = handleTrackerError(error)
tracker.product
.failedToEdit({
productName: 'User',
errorType: 'api',
fieldName: fieldName.trim(),
errorMessage: message
})
.track()
}
const toast = useToast()
const formSubmit = async (onSubmit, values) => {
await onSubmit()
Expand Down Expand Up @@ -107,6 +120,7 @@
@on-edit-success="handleResponse"
:updatedRedirect="props.updatedRedirect"
:schema="validationSchema"
@on-edit-fail="handleTrackFailedEdit"
>
<template #form>
<FormFieldsUsers
Expand Down

0 comments on commit 81fd322

Please sign in to comment.