Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-ISSUE] fix: correct method name for loading digital certificates in Add/Edit Domain Screen #2012

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

lucasmendes21
Copy link
Contributor

@lucasmendes21 lucasmendes21 commented Dec 11, 2024

Pull Request

What is the new behavior introduced by this PR?

fix: correct method name for loading digital certificates

Does this PR introduce breaking changes?

  • No
  • Yes

Does this PR introduce UI changes? Add a video or screenshots here.

No

Does it have a link on Figma?


Checklist

Make sure your pull request fits the checklist below (when applicable):

  • The issue title follows the format: [ISSUE_CODE] TYPE: TITLE
  • Commits are tagged with the right word (feat, test, refactor, etc)
  • Application responsiveness was tested to different screen sizes
  • Code is formatted and linted
  • Tags are added to the PR

These changes were tested on the following browsers:

  • Chrome
  • Edge
  • Firefox
  • Safari

@lucasmendes21 lucasmendes21 added the bug Something isn't working label Dec 11, 2024
@lucasmendes21 lucasmendes21 requested review from a team as code owners December 11, 2024 17:12
HerbertJulio
HerbertJulio previously approved these changes Dec 11, 2024
pauloSF0
pauloSF0 previously approved these changes Dec 11, 2024
@vinigfer
Copy link
Member

Please check which test should have caught this defect

@lucasmendes21 lucasmendes21 dismissed stale reviews from pauloSF0 and HerbertJulio via e40c1b5 December 11, 2024 18:05
HerbertJulio
HerbertJulio previously approved these changes Dec 11, 2024
@vinigfer vinigfer changed the title [NO-ISSUE] fix: correct method name for loading digital certificates [NO-ISSUE] fix: correct method name for loading digital certificates in Add/Edit Domain Screen Dec 11, 2024
@vinigfer vinigfer merged commit 20d8294 into dev Dec 11, 2024
8 of 12 checks passed
@vinigfer vinigfer deleted the NO-ISSUE-fix-adjust-service-name branch December 11, 2024 18:38
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

4 participants