Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UXE-5966] fix: incorrect argument when saving criteria rules engine #2038

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

lucasmendes21
Copy link
Contributor

Bug fix

incorrect argument when saving criteria rules engine

Explain what was fixed and the correct behavior.

should save exists and do_not_exists criteria without errors and without arguments

Does this PR introduce UI changes? Add a video or screenshots here.

NO


Checklist

Make sure your pull request fits the checklist below (when applicable):

  • The issue title follows the format: [ISSUE_CODE] bug: TITLE
  • Commits are tagged with the right word (feat, test, refactor, etc)
  • Application responsiveness was tested to different screen sizes
  • New tests are added to prevent the same issue from happening again
  • UI changes are validated by a team designer
  • Code is formatted and linted
  • Tags are added to the PR

These changes were tested on the following browsers:

  • Chrome
  • Edge
  • Firefox
  • Safari

@lucasmendes21 lucasmendes21 added the bug Something isn't working label Dec 20, 2024
@lucasmendes21 lucasmendes21 requested review from a team as code owners December 20, 2024 13:27
HerbertJulio
HerbertJulio previously approved these changes Dec 20, 2024
vinigfer
vinigfer previously approved these changes Dec 20, 2024
@lucasmendes21 lucasmendes21 dismissed stale reviews from vinigfer and HerbertJulio via 777cffc December 20, 2024 15:46
@vinigfer vinigfer merged commit 5ca1f13 into dev Dec 20, 2024
9 of 12 checks passed
@vinigfer vinigfer deleted the UXE-5966-incorrect-argument-rules-engine branch December 20, 2024 17:49
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

3 participants