Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UXE-5981] test: remove unused assert from domains test #2044

Merged
merged 1 commit into from
Dec 23, 2024
Merged

[UXE-5981] test: remove unused assert from domains test #2044

merged 1 commit into from
Dec 23, 2024

Conversation

aloisio-m-bastian
Copy link
Contributor

Pull Request

What is the new behavior introduced by this PR?

Remove unused assert causing errors in domains tests

Does this PR introduce breaking changes?

  • No
  • Yes

Does this PR introduce UI changes? Add a video or screenshots here.

Does it have a link on Figma?

Checklist

Make sure your pull request fits the checklist below (when applicable):

  • The issue title follows the format: [ISSUE_CODE] TYPE: TITLE
  • Commits are tagged with the right word (feat, test, refactor, etc)
  • Application responsiveness was tested to different screen sizes
  • Code is formatted and linted
  • Tags are added to the PR

These changes were tested on the following browsers:

  • Chrome
  • Edge
  • Firefox
  • Safari

@aloisio-m-bastian aloisio-m-bastian self-assigned this Dec 23, 2024
@aloisio-m-bastian aloisio-m-bastian requested review from a team as code owners December 23, 2024 19:33
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@aloisio-m-bastian aloisio-m-bastian merged commit 27ea363 into dev Dec 23, 2024
13 of 15 checks passed
@aloisio-m-bastian aloisio-m-bastian deleted the UXE-5981 branch December 23, 2024 20:07
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lucasmendes21 lucasmendes21 lucasmendes21 approved these changes

@peterpaulo-azion peterpaulo-azion peterpaulo-azion approved these changes

Assignees

@aloisio-m-bastian aloisio-m-bastian

Labels
e2e tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aloisio-m-bastian @lucasmendes21 @peterpaulo-azion