Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UXE-4724] fix: capture groups input gaps #2047

Merged
merged 3 commits into from
Jan 8, 2025
Merged

[UXE-4724] fix: capture groups input gaps #2047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb46082
fix: capture groups input gaps
lfsigreja Dec 23, 2024
9169a84
Merge branch 'dev' into uxe-4724
pauloSF0 Jan 7, 2025
016a8b5
chore: merged with dev branch
pauloSF0 Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/services/waf-rules-services/v4/create-waf-rules-service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const adapt = (payload) => {
cross_site_scripting: payload.crossSiteScripting,
directory_traversal: payload.directoryTraversal,
remote_file_inclusion: payload.remoteFileInclusion,
sql_injection: payload.sqlInjection,
sql_injection: payload.sqlInjection
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/services/waf-rules-services/v4/edit-waf-rules-service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,4 @@ const parseHttpResponse = (httpResponse) => {
default:
throw new Error(extractApiError(httpResponse)).message
}
}
}
1 change: 1 addition & 0 deletions src/templates/form-fields-inputs/fieldText.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@

<template>
<LabelBlock
v-if="props.label"
:for="props.name"
:data-testid="customTestId.label"
:label="props.label"
Expand Down
2 changes: 1 addition & 1 deletion src/tests/services/waf-rules-services/v4/edit-waf-rules-service.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ describe('WafRulesServices', () => {
cross_site_scripting: fixtures.wafRulesMock.crossSiteScripting,
directory_traversal: fixtures.wafRulesMock.directoryTraversal,
remote_file_inclusion: fixtures.wafRulesMock.remoteFileInclusion,
sql_injection: fixtures.wafRulesMock.sqlInjection,
sql_injection: fixtures.wafRulesMock.sqlInjection
},
id: fixtures.wafRulesMock.id,
name: fixtures.wafRulesMock.name,
Expand Down
7 changes: 2 additions & 5 deletions src/views/EdgeApplicationsRulesEngine/FormFields/FormFieldsEdgeApplicationsRulesEngine.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,26 +878,23 @@
</FieldDropdown>
</template>
<template v-else-if="behaviorItem.value.name === 'capture_match_groups'">
<div class="flex flex-col w-full">
<div class="flex gap-3 flex-col w-full">
<FieldText
class="w-full mb-3"
:name="`behaviors[${behaviorIndex}].captured_array`"
:key="behaviorItem.key"
placeholder="captured array name"
placeholder="Captured array name"
:value="behaviors[behaviorIndex].value.captured_array"
:data-testid="`edge-application-rule-form__behaviors-item-capture-match-groups-captured-array[${behaviorIndex}]`"
/>
<FieldText
placeholder="Subject"
class="w-full mb-3"
:name="`behaviors[${behaviorIndex}].subject`"
:key="behaviorItem.key"
:value="behaviors[behaviorIndex].value.subject"
:data-testid="`edge-application-rule-form__behaviors-item-capture-match-groups-subject[${behaviorIndex}]`"
/>
<FieldText
placeholder="Regex"
class="w-full"
:name="`behaviors[${behaviorIndex}].regex`"
:key="behaviorItem.key"
:value="behaviors[behaviorIndex].value.regex"
Expand Down
Loading