Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UXE-5366] fix: standardize edge functions titles to display item names instead of product names #2048

Merged
merged 1 commit into from
Jan 7, 2025
Merged

[UXE-5366] fix: standardize edge functions titles to display item names instead of product names #2048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/views/EdgeFunctions/EditView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
})
const updateObject = ref({})
const language = ref(null)
const name = ref('')
const handleTrackSuccessEdit = () => {
tracker.product
Expand Down Expand Up @@ -67,7 +68,7 @@
<template>
<ContentBlock>
<template #heading>
<PageHeadingBlock pageTitle="Edit Edge Function">
<PageHeadingBlock :pageTitle="name">
<MobileCodePreview
:updateObject="updateObject"
:language="language"
Expand All @@ -87,6 +88,7 @@
<FormFieldsEditEdgeFunctions
v-model:preview-data="updateObject"
v-model:lang="language"
v-model:name="name"
/>
</template>
<template #action-bar="{ onSubmit, onCancel, loading }">
Expand Down
3 changes: 2 additions & 1 deletion src/views/EdgeFunctions/FormFields/FormFieldsEditEdgeFunctions.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import { computed, ref, watch } from 'vue'

defineProps(['previewData', 'lang'])
const emit = defineEmits(['update:previewData', 'update:lang'])
const emit = defineEmits(['update:previewData', 'update:lang', 'update:name'])

const SPLITTER_PROPS = {
height: '50vh',
Expand All @@ -40,6 +40,7 @@
const unwatch = watch(name, () => {
initialCodeValue = code.value
initialJsonArgsValue = jsonArgs.value
emit('update:name', name.value)

if (initialCodeValue) {
unwatch()
Expand Down
Loading