Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UXE-5977] hotfix: fixed variable names in edge firewall #2050

Closed

Conversation

HerbertJulio
Copy link
Collaborator

Bug fix

Explain what was fixed and the correct behavior.

This pull request includes changes to the FormFieldsEdgeFirewallRulesEngine.vue file to improve the maintainability and readability of the code by using template literals for specific string values.

Codebase improvements:

Does this PR introduce UI changes? Add a video or screenshots here.


Checklist

Make sure your pull request fits the checklist below (when applicable):

  • The issue title follows the format: [ISSUE_CODE] bug: TITLE
  • Commits are tagged with the right word (feat, test, refactor, etc)
  • Application responsiveness was tested to different screen sizes
  • New tests are added to prevent the same issue from happening again
  • UI changes are validated by a team designer
  • Code is formatted and linted
  • Tags are added to the PR

These changes were tested on the following browsers:

  • Chrome
  • Edge
  • Firefox
  • Safari

@HerbertJulio HerbertJulio self-assigned this Dec 24, 2024
@HerbertJulio HerbertJulio requested review from a team as code owners December 24, 2024 15:00
@HerbertJulio HerbertJulio added the bug Something isn't working label Dec 24, 2024
pauloSF0
pauloSF0 previously approved these changes Jan 6, 2025
lucasmendes21
lucasmendes21 previously approved these changes Jan 6, 2025
@HerbertJulio HerbertJulio changed the title [UXE-5979] fix: update variable names in edge firewall [UXE-5979] fix: fixed variable names in edge firewall Jan 6, 2025
@HerbertJulio HerbertJulio changed the base branch from dev to main January 6, 2025 16:49
@HerbertJulio HerbertJulio dismissed stale reviews from lucasmendes21, aloisio-m-bastian, and pauloSF0 January 6, 2025 16:49

The base branch was changed.

@HerbertJulio HerbertJulio changed the title [UXE-5979] fix: fixed variable names in edge firewall [UXE-5977] hotfix: fixed variable names in edge firewall Jan 6, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

4 participants