Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UXE-5889] feat: migrate network lists/domains filters in WAF Tunning for API v4 #2088

Merged
merged 12 commits into from
Feb 3, 2025
Merged

[UXE-5889] feat: migrate network lists/domains filters in WAF Tunning for API v4 #2088

merged 12 commits into from
Feb 3, 2025

Conversation

peterpaulo-azion
Copy link
Contributor

@peterpaulo-azion peterpaulo-azion commented Jan 23, 2025 •
edited
Loading

Pull Request

What is the new behavior introduced by this PR?

  • migrate network lists and domains dropdown in waf rules tuning
  • create a fieldMultiselectLazyLoader component
  • test case to new v4 service
  • v4 migrate get by ID domain and network list

Does this PR introduce breaking changes?

  • No
  • Yes

Does this PR introduce UI changes? Add a video or screenshots here.

Does it have a link on Figma?

Checklist

Make sure your pull request fits the checklist below (when applicable):

  • The issue title follows the format: [ISSUE_CODE] TYPE: TITLE
  • Commits are tagged with the right word (feat, test, refactor, etc)
  • Application responsiveness was tested to different screen sizes
  • Code is formatted and linted
  • Tags are added to the PR

These changes were tested on the following browsers:

  • Chrome
  • Edge
  • Firefox
  • Safari

@peterpaulo-azion peterpaulo-azion self-assigned this Jan 23, 2025
@peterpaulo-azion peterpaulo-azion requested review from a team as code owners January 23, 2025 17:27
HerbertJulio
HerbertJulio previously approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@HerbertJulio HerbertJulio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

HerbertJulio
HerbertJulio previously approved these changes Jan 28, 2025
View reviewed changes
pauloSF0
pauloSF0 previously approved these changes Jan 28, 2025
View reviewed changes
HerbertJulio
HerbertJulio previously approved these changes Jan 28, 2025
View reviewed changes
pauloSF0
pauloSF0 previously approved these changes Jan 28, 2025
View reviewed changes
@vinigfer vinigfer changed the title [UXE-5889] feat: migrate network lists and domains dropdown in waf rules tuning [UXE-5889] feat: migrate network lists/domains filters in WAF Tunning for API v4 Feb 3, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
1.4% Coverage on New Code (required ≥ 80%)
3.9% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@peterpaulo-azion peterpaulo-azion merged commit 5c25f57 into dev Feb 3, 2025
12 of 15 checks passed
@peterpaulo-azion peterpaulo-azion deleted the uxe-5889-dropdown-waf-rules branch February 3, 2025 19:46
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lucasmendes21 lucasmendes21 lucasmendes21 approved these changes

@HerbertJulio HerbertJulio HerbertJulio approved these changes

@pauloSF0 pauloSF0 pauloSF0 left review comments

Assignees

@peterpaulo-azion peterpaulo-azion

Labels
api-v4-migration
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peterpaulo-azion @lucasmendes21 @HerbertJulio @pauloSF0