Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO-ISSUE] fix: change success status in edge dns create api response #2126

Merged
merged 1 commit into from
Feb 5, 2025
Merged

[NO-ISSUE] fix: change success status in edge dns create api response #2126

merged 1 commit into from
Feb 5, 2025

Conversation

aloisio-m-bastian
Copy link
Contributor

Bug fix

Explain what was fixed and the correct behavior.

change success status in edge dns create api response

Does this PR introduce UI changes? Add a video or screenshots here.

Checklist

Make sure your pull request fits the checklist below (when applicable):

  • The issue title follows the format: [ISSUE_CODE] bug: TITLE
  • Commits are tagged with the right word (feat, test, refactor, etc)
  • Application responsiveness was tested to different screen sizes
  • New tests are added to prevent the same issue from happening again
  • UI changes are validated by a team designer
  • Code is formatted and linted
  • Tags are added to the PR

These changes were tested on the following browsers:

  • Chrome
  • Edge
  • Firefox
  • Safari
  • Brave

@aloisio-m-bastian aloisio-m-bastian requested review from a team as code owners February 5, 2025 13:33
@aloisio-m-bastian aloisio-m-bastian self-assigned this Feb 5, 2025
@aloisio-m-bastian aloisio-m-bastian added the bug Something isn't working label Feb 5, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vinigfer vinigfer merged commit ad9256d into dev Feb 5, 2025
14 of 16 checks passed
@vinigfer vinigfer deleted the fix-edge-dns-creatioj branch February 5, 2025 13:57
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vinigfer vinigfer vinigfer approved these changes

@peterpaulo-azion peterpaulo-azion peterpaulo-azion approved these changes

Assignees

@aloisio-m-bastian aloisio-m-bastian

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aloisio-m-bastian @vinigfer @peterpaulo-azion