Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ajust-OpenAPI-EdgeApp---type-weight-to-int #155

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

VitorAEltz
Copy link
Contributor

@VitorAEltz VitorAEltz commented Dec 19, 2023

Update CreateOriginsRequest_addresses Schema

This Pull Request includes updates to the CreateOriginsRequest_addresses and OriginsResultResponse_addresses schemas in the edgeapplications.yaml file.

Changes:

  1. Added is_active, weight, and server_role properties to the CreateOriginsRequest_addresses schema. These properties are necessary to align the request schema with the OriginsResultResponse_addresses schema.

  2. Updated the weight property in the OriginsResultResponse_addresses schema from a string type to an integer type. This change aligns with the data type of the weight property in the CreateOriginsRequest_addresses schema.

  3. Added format: int64 to the weight property in the CreateOriginsRequest_addresses schema. This specifies that the weight property should be a 64-bit integer.

These changes ensure consistency between the request and response schemas and provide clearer expectations for the API users about what data should be included in the request and what data they can expect in the response.

@VitorAEltz VitorAEltz requested a review from a team as a code owner December 19, 2023 17:42
azionhsantos
azionhsantos previously approved these changes Dec 19, 2023
Copy link
Contributor

@trgalho trgalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VitorAEltz VitorAEltz changed the title Ajust-OpenAPI-EdgeApp---type-weight-to-int fix: Ajust-OpenAPI-EdgeApp---type-weight-to-int Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants