Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: edge storage #204

Merged
merged 6 commits into from
Mar 27, 2024
Merged

fix: edge storage #204

merged 6 commits into from
Mar 27, 2024

Conversation

maxwelbm
Copy link
Contributor

@maxwelbm maxwelbm commented Mar 26, 2024 •
edited
Loading

  • command update bucket, added field edge_access
  • params continuam_token, max_object_count added to command get objects to pagination
  • body response get object

@maxwelbm maxwelbm added the bug Something isn't working label Mar 26, 2024
@maxwelbm maxwelbm self-assigned this Mar 26, 2024
@maxwelbm maxwelbm requested a review from a team as a code owner March 26, 2024 13:44
pablodiehl
pablodiehl previously approved these changes Mar 26, 2024
View reviewed changes
@maxwelbm maxwelbm requested a review from PatrickMenoti March 26, 2024 15:14
@maxwelbm maxwelbm changed the title fix: added params required to api get objects fix: edge storage Mar 26, 2024
PatrickMenoti
PatrickMenoti previously approved these changes Mar 26, 2024
View reviewed changes
@maxwelbm maxwelbm dismissed stale reviews from PatrickMenoti and pablodiehl via 4665ae2 March 26, 2024 23:37
pablodiehl
pablodiehl previously approved these changes Mar 27, 2024
View reviewed changes
alisson-marcelo-azion
alisson-marcelo-azion previously requested changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@alisson-marcelo-azion alisson-marcelo-azion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be auto generated. Is it just a copy from https://github.com/aziontech/storage-api/blob/dev/openapi-schema.yml?

@alisson-marcelo-azion alisson-marcelo-azion dismissed their stale review March 27, 2024 13:46

Waiting for approval from core team

@maxwelbm maxwelbm merged commit 90dc9cb into main Mar 27, 2024
3 checks passed
@maxwelbm maxwelbm deleted the fix/not_params_required_api_objects_storage branch March 27, 2024 13:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@helio-neto helio-neto helio-neto approved these changes

@pablodiehl pablodiehl pablodiehl approved these changes

@PatrickMenoti PatrickMenoti PatrickMenoti approved these changes

@alisson-marcelo-azion alisson-marcelo-azion alisson-marcelo-azion left review comments

Assignees

@maxwelbm maxwelbm

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maxwelbm @helio-neto @pablodiehl @alisson-marcelo-azion @PatrickMenoti