Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Jenkins: No way to configure JenkinsInfoProvider #2926

Open
2 tasks done
manusant opened this issue Feb 17, 2025 · 2 comments
Open
2 tasks done

🐛 Jenkins: No way to configure JenkinsInfoProvider #2926

manusant opened this issue Feb 17, 2025 · 2 comments
Labels
bug Something isn't working contribfest help wanted Extra attention is needed

Comments

@manusant
Copy link

manusant commented Feb 17, 2025

Workspace

jenkins

📜 Description

We've been using the Jenkins plugin with a custom JenkinsInfoProvider implementation through the createRouter function for a wile. After the latest changes in the plugin, the createRouter is no longer exported, but there is now plugin extension point to allow us to provide our custom implementation.

As i could check from the plugin code, the JenkinsInfoProvider is hardcoded inside the plugin initialiser and there is no way to supply i bespoke version as documented. By the way the plugin doc might be missing info on how to set this up.

👍 Expected behavior

Since this capability is already there, i would propose creating an extension point for the InfoProvider to allow users to override the default one.

👎 Actual Behavior with Screenshots

Image

👟 Reproduction steps

No need

📃 Provide the context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

None

@manusant manusant added the bug Something isn't working label Feb 17, 2025
@vinzscam vinzscam added contribfest help wanted Extra attention is needed labels Feb 25, 2025
@vinzscam
Copy link
Member

yep, it looks like an extension point is missing. Marked as help wanted

lcarva added a commit to lcarva/backstage-community-plugins that referenced this issue Feb 26, 2025
Add an extension point to the `jenkins-backend` plugin so a custom
JenkinsInforProvider can be used.

Fixes backstage#2926

Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
@lcarva
Copy link

lcarva commented Feb 26, 2025

@manusant, I made an attempt at this on #3000. Could you have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working contribfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants