Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: ADR plugin failed to render the image #2959

Open
2 tasks done
yoramshai opened this issue Feb 19, 2025 · 2 comments
Open
2 tasks done

🐛 Bug Report: ADR plugin failed to render the image #2959

yoramshai opened this issue Feb 19, 2025 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@yoramshai
Copy link

yoramshai commented Feb 19, 2025

📜 Description

I'm encountering a "Bad Request (400)" error when attempting to display an image from GitHub.

"@backstage-community/plugin-adr": "^0.8.0",
"@backstage-community/plugin-adr-backend": "^0.6.0",

Image

Image

👍 Expected behavior

image will be rendered and show up in Backstage ADR.

👎 Actual Behavior with Screenshots

the image is broken.

👟 Reproduction steps

  1. Install ADR plugin.
  2. add ADR MD file with attachment
  3. open the ADR

📃 Provide the context for the Bug.

No response

🖥️ Your Environment

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

None

@yoramshai yoramshai added the bug Something isn't working label Feb 19, 2025
@Rugvip Rugvip transferred this issue from backstage/backstage Feb 20, 2025
@BethGriggs BethGriggs added the help wanted Extra attention is needed label Feb 20, 2025
@vinzscam
Copy link
Member

cc @kuangp 🙏

@kuangp
Copy link
Member

kuangp commented Feb 28, 2025

hi @yoramshai it looks like the linked image url is not one that is currently supported - the plugin requires a direct url to a image file that typically ends in one of these supported file type extensions. GitHub user attachment asset urls looks to be proxy urls to actual file locations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants