azure-storage-explorer - Removed usages and references of @backstage/backend-common

workspaces/azure-storage-explorer/.changeset/weak-shirts-run.md

@@ -0,0 +1,5 @@
+---
+'@backstage-community/plugin-azure-storage-explorer-backend': patch
+---
+
+Removed usages and references of `@backstage/backend-common`

workspaces/azure-storage-explorer/packages/backend/knip-report.md

@@ -10,7 +10,6 @@
 | @backstage/plugin-permission-common                        | package.json | error    |
 | @backstage/plugin-permission-node                          | package.json | error    |
 | @backstage/plugin-auth-node                                | package.json | error    |
-| @backstage/backend-common                                  | package.json | error    |
 | @backstage/catalog-client                                  | package.json | error    |
 | @backstage/backend-tasks                                   | package.json | error    |
 | @backstage/config                                          | package.json | error    |

workspaces/azure-storage-explorer/packages/backend/package.json

@@ -22,7 +22,6 @@
   },
   "dependencies": {
     "@backstage-community/plugin-azure-storage-explorer-backend": "workspace:^",
-    "@backstage/backend-common": "^0.25.0",
     "@backstage/backend-defaults": "^0.5.2",
     "@backstage/backend-tasks": "^0.6.1",
     "@backstage/catalog-client": "^1.7.1",

workspaces/azure-storage-explorer/plugins/azure-storage-backend/package.json

@@ -40,19 +40,18 @@
   "dependencies": {
     "@azure/identity": "4.4.1",
     "@azure/storage-blob": "12.24.0",
-    "@backstage/backend-common": "^0.25.0",
     "@backstage/backend-plugin-api": "^1.0.1",
     "@backstage/config": "^1.2.0",
     "@backstage/errors": "^1.2.4",
     "@types/express": "*",
     "express": "^4.17.1",
     "express-promise-router": "^4.1.0",
     "node-fetch": "^2.6.7",
-    "winston": "^3.2.1",
     "yn": "^4.0.0"
   },
   "devDependencies": {
     "@backstage/backend-defaults": "^0.5.2",
+    "@backstage/backend-test-utils": "1.0.2",
     "@backstage/cli": "^0.28.0",
     "@backstage/plugin-auth-backend": "^0.23.1",
     "@backstage/plugin-auth-backend-module-guest-provider": "^0.2.1",

workspaces/azure-storage-explorer/plugins/azure-storage-backend/report.api.md

@@ -3,9 +3,11 @@
 > Do not edit this file. It is a report generated by [API Extractor](https://api-extractor.com/).
 
 ```ts
+/// <reference types="express" />
+
 import { BackendFeature } from '@backstage/backend-plugin-api';
 import { Config } from '@backstage/config';
-import { Logger } from 'winston';
+import { LoggerService } from '@backstage/backend-plugin-api';
 import { Router } from 'express';
 
 // @public (undocumented)
@@ -20,7 +22,7 @@ export interface RouterOptions {
   // (undocumented)
   config: Config;
   // (undocumented)
-  logger: Logger;
+  logger: LoggerService;
 }
 
 // (No @packageDocumentation comment for this package)

workspaces/azure-storage-explorer/plugins/azure-storage-backend/src/plugin.ts

@@ -13,7 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import { loggerToWinstonLogger } from '@backstage/backend-common';
+
 import {
   coreServices,
   createBackendPlugin,
@@ -33,7 +33,7 @@ export const azureStoragePlugin = createBackendPlugin({
       async init({ config, logger, httpRouter }) {
         httpRouter.use(
           await createRouter({
-            logger: loggerToWinstonLogger(logger),
+            logger: logger,
             config,
           }),
         );

workspaces/azure-storage-explorer/plugins/azure-storage-backend/src/service/AzureStorageBuilder.ts

@@ -13,16 +13,16 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import { Logger } from 'winston';
+
 import { AzureStorageProvider } from './AzureStorageProvider';
 import { Config } from '@backstage/config';
 import Router from 'express-promise-router';
 import express from 'express';
 import { NotFoundError } from '@backstage/errors';
-import { errorHandler } from '@backstage/backend-common';
+import { LoggerService } from '@backstage/backend-plugin-api';
 
 export interface AzureStorageEnv {
-  logger: Logger;
+  logger: LoggerService;
   config: Config;
 }
 
@@ -59,7 +59,7 @@ export class AzureStorageBuilder {
 
   protected buildRouter(
     azureStorageProvider: AzureStorageProvider,
-    logger: Logger,
+    logger: LoggerService,
   ): express.Router {
     const router = Router();
     router.use(express.json());
@@ -118,8 +118,6 @@ export class AzureStorageBuilder {
       },
     );
 
-    router.use(errorHandler());
-
     return router;
   }
 }

workspaces/azure-storage-explorer/plugins/azure-storage-backend/src/service/router.test.ts

@@ -13,7 +13,8 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import { getVoidLogger } from '@backstage/backend-common';
+
+import { mockServices } from '@backstage/backend-test-utils';
 import express from 'express';
 import request from 'supertest';
 import { ConfigReader } from '@backstage/config';
@@ -25,7 +26,7 @@ describe('createRouter', () => {
 
   beforeAll(async () => {
     const router = await createRouter({
-      logger: getVoidLogger(),
+      logger: mockServices.rootLogger(),
       config: new ConfigReader({
         azureStorage: {
           blobContainers: [

workspaces/azure-storage-explorer/plugins/azure-storage-backend/src/service/router.ts

@@ -14,12 +14,12 @@
  * limitations under the License.
  */
 import { Config } from '@backstage/config';
-import { Logger } from 'winston';
 import { AzureStorageBuilder } from './AzureStorageBuilder';
+import { LoggerService } from '@backstage/backend-plugin-api';
 
 /** @public */
 export interface RouterOptions {
-  logger: Logger;
+  logger: LoggerService;
   config: Config;
 }